SWIFT-221 Provide better consistency around Int usage with Documents #235
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patrickfreed
commented
Apr 10, 2019
mbroadst
reviewed
Apr 12, 2019
kmahar
reviewed
Apr 15, 2019
Contributor
kmahar
left a comment
kmahar
left a comment
There was a problem hiding this comment.
looks good overall, just some suggestions and questions.
kmahar
approved these changes
Apr 16, 2019
Contributor
kmahar
left a comment
kmahar
left a comment
There was a problem hiding this comment.
lgtm! this was a very tricky API to think through, great job 👏
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SWIFT-221
This PR changes the way integers are read from and written with
Document.On 64-bit systems:
Int32Int32will be written to BSON int32IntInt64will be written to BSON int64Intwill be written to BSON int64On 32-bit systems:
IntInt32will be written to BSON int32Int64Int64will be written to BSON int64Intwill be written to BSON int32This has the notable effect that
Intwill always be round tripped, though it will be in a size according to the cpu arch.Also as part of this PR, the protocol
BSONNumberwas introduced. All numeric values that conform toBSONValueshould conform toBSONNumberas well. It facilitates conversion to the numeric types that have native representations in BSON.